orcasound / orcamap-react

ReactJS version of Orcamap (current version of orcamap project)
MIT License
23 stars 34 forks source link

Issue & PR templates; README changes; #30

Closed sahil-shubham closed 3 years ago

sahil-shubham commented 3 years ago

Changes

netlify[bot] commented 3 years ago

Deploy request for orcamap accepted.

Accepted with commit e9add47ca3065eb8b6f1a9e2631071c508c95a2c

https://app.netlify.com/sites/orcamap/deploys/6056d741c53fc50007f4c852

sahil-shubham commented 3 years ago

I found few issues with little or no description, which was a hindrance for me and could be the same for first time contributors. I also noticed lack of description in open pull requests, a good description and overview for a pull request can help maintainers in reviewing and also help other contributors in understanding what someone else worked on without looking at the code.

I also made some changes to guide first time contributors to the CONTRIBUTING.md.

Please take a look and let me know of any changes, thank you.

sahil-shubham commented 3 years ago

@ivanoats I think this PR became redundant due to another PR bringing the same changes, at the moment this doesn't bring any significant changes and you could proceed with closing this PR if necessary, thank you for reviewing this @parthsarthiprasad and @ivanoats