orcasound / orcasite

Live-listening web app -- http://live.orcasound.net :star:
http://live.orcasound.net
GNU Affero General Public License v3.0
59 stars 52 forks source link

Sunset Bay vs Beach Camp at Sunset Bay #551

Open dthaler opened 4 months ago

dthaler commented 4 months ago

Describe the bug The name of this hydrophone is inconsistent.

To Reproduce

Expected behavior

The display name should be consistent across all sites. I suggest "Sunset Bay".

Additional context

This inconsistency required me to hard code a special case in Orcanode Monitor to match entries across services. (The special case I currently use is to look for " at " and if found then only use what follows the " ai ".)

paulcretu commented 3 months ago

Renaming to "Sunset Bay" makes sense to me, but I'll let @scottveirs chime in / make the change.

That said, I think it would be ideal to rely on the display name (name field) from the DB (https://live.orcasound.net/api/json/feeds) for deciding what to display elsewhere. The best way to get around the hard coding issue is to track all the different identifiers into the DB, so then we have a mapping between everything and the API endpoint can be a source of truth.

I know @skanderm already added the dataplicity ID—it might also be good to track the ai4orcas ID as well as the wordpress page