orcestra-campaign / book

ORCESTRA documentation
8 stars 42 forks source link

Adds goes2go to the environment #479

Closed JuliaWindmiller1987 closed 2 months ago

JuliaWindmiller1987 commented 2 months ago

To be able to plot the flight track on the corresponding satellite image I am using the goes2go package. I use goes2go rather than NASA Worldview because it uses the long term storage of the data at AWS while Worldview only offers GOES data for the last 90 days.

lkluft commented 2 months ago

I think this really depends on what scope we want the environment.yaml to have. If we mean it as the minimum set of dependencies to build the book, then we don't need goes2go yet. If we also see it as the default Python environment that people should use during ORCESTRA, I am fine with adding it. @d70-t do you have an opinion?

d70-t commented 2 months ago

My opinion would be, that the environment should only cover what's needed to build the book.

However, I also think that the book should automatically plot the tracks in the flight reports. So it may be, that we'll eventually need goes2go. But I wouldn't want to include it in the environment before we actually need it.

lkluft commented 2 months ago

I agree, so let's keep goes2go out of the environment until the tracks are built inside the book. I would also argue that the ModuleNotFoundError should be easy to handle for users running the post-flight notebooks with the orcestra_book environment.