search

orchestracities / auth-management-ui

An UI for Anubis and FIWARE-based platforms
https://master--62bcedd6cc1b1300eb9e1607.chromatic.com/
Apache License 2.0
0 stars 1 forks source link

Documentation #35

Closed Valecant closed 2 years ago

Valecant commented 2 years ago

to set it up cd documentation npm install npm run storybook

is running on port 6006

chicco785 commented 2 years ago

to set it up cd documentation npm install npm run storybook

is running on port 6006

this should be a section in the readme

chicco785 commented 2 years ago

to set it up cd documentation npm install npm run storybook is running on port 6006

this should be a section in the readme

and this also not enough:

oduleNotFoundError: Module not found: Error: Can't resolve '@mui/material/utils' in '/Users/facca/Code/orchestracities/auth-management-ui/node_modules/@mui/icons-material/utils' at /Users/facca/Code/orchestracities/auth-management-ui/documentation/node_modules/webpack/lib/Compilation.js:925:10 at /Users/facca/Code/orchestracities/auth-management-ui/documentation/node_modules/webpack/lib/NormalModuleFactory.js:401:22 at /Users/facca/Code/orchestracities/auth-management-ui/documentation/node_modules/webpack/lib/NormalModuleFactory.js:130:21 at /Users/facca/Code/orchestracities/auth-management-ui/documentation/node_modules/webpack/lib/NormalModuleFactory.js:224:22 at /Users/facca/Code/orchestracities/auth-management-ui/documentation/node_modules/neo-async/async.js:2830:7 at /Users/facca/Code/orchestracities/auth-management-ui/documentation/node_modules/neo-async/async.js:6877:13 at /Users/facca/Code/orchestracities/auth-management-ui/documentation/node_modules/webpack/lib/NormalModuleFactory.js:214:25 at /Users/facca/Code/orchestracities/auth-management-ui/documentation/node_modules/enhanced-resolve/lib/Resolver.js:213:14 at /Users/facca/Code/orchestracities/auth-management-ui/documentation/node_modules/enhanced-resolve/lib/Resolver.js:285:5 at eval (eval at create (/Users/facca/Code/orchestracities/auth-management-ui/documentation/node_modules/tapable/lib/HookCodeFactory.js:33:10), :15:1) resolve '@mui/material/utils' in '/Users/facca/Code/orchestracities/auth-management-ui/node_modules/@mui/icons-material/utils'

the ui need to be installed as well

chicco785 commented 2 years ago

@Valecant

  1. add ci linting workflow also for documentation, so that style of code here and in app is uniform

this means adding the workflow in github, not just running the linting locally.

see what i have done: https://github.com/orchestracities/auth-management-ui/blob/f14c0327fa5cf89267fd2b6c571a9f463a2e4301/.github/workflows/lint.yml#L37-L42

chicco785 commented 2 years ago

Line of texts should be shorted than 80 charts, or its difficult to do line by line review.

this was not applied... i am doing it