orchestracities / ngsi-timeseries-api

QuantumLeap: a FIWARE Generic Enabler to support the usage of NGSIv2 (and NGSI-LD experimentally) data in time-series databases
https://quantumleap.rtfd.io/
MIT License
38 stars 49 forks source link

added object type for array #575

Open pooja1pathak opened 3 years ago

pooja1pathak commented 3 years ago

Proposed changes

Added object(ignored) type for array. Fix for issue #147

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

"Martel Open Source Software Individual Contributor License Agreement"
"Contributing to QuantumLeap"
github-actions[bot] commented 3 years ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️

pooja1pathak commented 2 years ago

@c0c0n3 @chicco785 Please confirm about the changes. Does it fits our need or I need to look into other approach. I tried to fix failing test cases but unable to do so. I will update the test cases after changes are confirmed and CircleCI issue is fixed.

chicco785 commented 2 years ago

@pooja1pathak please also add tests and update the changelog. many thanks.

chicco785 commented 2 years ago

the new type breaks something in the code

pooja1pathak commented 2 years ago

the new type breaks something in the code

Yes, I am looking into it. I'll update once I fix this