Open chicco785 opened 2 years ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️
actually the change from dynamic
to strict
was introduced my me here:
https://github.com/orchestracities/ngsi-timeseries-api/commit/57f721f74610028bd658eb7b2f45bfbe6d415957
the reason why this is now an issue, is that instanceId
it's not tracked in metadata, thus, we don't know if it is missing or not, when adding new data.
@chicco785 cool, thanks for this! We should keep a lid on the box :-)
Let's merge this PR when we've got a fix for #638. Here's what I have in mind
instanceid
is handled correctly (metadata, etc.) but it can leave out backward compat tests.Thoughts?
sure, this pr should be use as a base for the fix, since it reproduces the issue.
Proposed changes
@StWiemann found out that upgrade from 0.8.2 generate some issues. for some reason when inserting new data in a old table, instanceId column is not added, generating issues. (this could be actually due to some change in cratedb, we haven't handled properly) this pr surface the issue in bc testing (at least it should). moreover, this pr, by fixing a configuration issue in the backward test script, also evidenced an issue with a PR just merged (#564):
/
as service path, old data withNone
service path are not updated. thus queries to check old data with the new logic, of course fail. (this the reason why some lines are now commented - otherwise the test would bomb before detecting the issue exposed above.The pr is not yet a fix. It's just to reproduced in a controlled environment the issue.
Types of changes
What types of changes does your code introduce to the project? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
N/A