Closed wistefan closed 2 years ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️
I have read the CLA Document and I hereby sign the CLA
hi @wistefan and welcome on board! Thanks so much for your contrib! I've done a first review, see my comments there. Basically if you've tested the fix we could keep it---I'm just not sure about the read_env call having the effect you're hoping for, so if you could please double check.
Thanks a million!!
Proposed changes
The change reads out the enviornment variables for connection data on translator connection. This is required, because else the health-check fails until the first real call is made to the api. This leads to a deadlock in k8s environments, since no call is possible before its healthy.
Types of changes
What types of changes does your code introduce to the project? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments