Resolved TODO at line 44 in sql_translator.py

pooja1pathak commented 2 years ago

Proposed changes

fix for issue #650

Types of changes

What types of changes does your code introduce to the project? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Maintenance (update of libraries or other dependences)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have run all the existing tests locally (not just those related to my feature) and there are no errors
[x] After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
[x] I have updated the RELEASE NOTES
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

"Martel Open Source Software Individual Contributor License Agreement"

"Contributing to QuantumLeap"

"QuantumLeap Release Notes"

github-actions[bot] commented 2 years ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️

c0c0n3 commented 2 years ago

@pooja1pathak that's great, thanks! If you could just zap this line before we merge:

https://github.com/orchestracities/ngsi-timeseries-api/blob/master/src/translators/sql_translator.py#L44

since that TODO is no longer applicable :-)

pooja1pathak commented 2 years ago

done :)

c0c0n3 commented 2 years ago

@pooja1pathak we still don't have a green bar on CircleCI. It looks like this has nothing to do with your PR actually. In fact, the reason for the CircleCI failure is this reporter test: test_aggregation_different_attribute_types.py. I've tested your branch locally and I don't get that failure, all reporter tests actually pass. Here are the steps I followed to run the tests on your branch:

$ git clone https://github.com/pooja1pathak/ngsi-timeseries-api.git
$ cd ngsi-timeseries-api/
$ git checkout fix650
$ pipenv install --dev
$ export PIPENV_SHELL=no
$ source setup_dev_env.sh
$ export tests=reporter
$ pipenv run sh run_tests.sh
. . . (clipped output)
src/reporter/tests/test_1T1E1A.py ........................................                             [  4%]
src/reporter/tests/test_aggregation_different_attribute_types.py ..                                    [ 65%]
. . . (clipped output)
src/reporter/tests/test_version.py .                                                                   [100%]
. . . (clipped output)
============================ 968 passed, 6 skipped, 1 warnings in 425.27 seconds ============================

@chicco785 can you please try re-running the reporter tests on CircleCI---I get the "rerun" button when I log in, but clicking on it has no effect it seems.

pooja1pathak commented 2 years ago

done. success on circle ci

orchestracities / ngsi-timeseries-api