Closed NEC-Vishal closed 2 years ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️
Hi @chicco785 @c0c0n3 can you please check the workflow?
hi @NEC-Vishal! Thank you sooo much for this PR. I've checked out your branch locally and the tests break on my side too. Not sure why. Can you please try running all the tests locally too? Some of them should break for you too, maybe you can help us figure out what's wrong...
I have read the CLA Document and I hereby sign the CLA
Hi @c0c0n3 @chicco785 can you please check this PR now for issue #648. I have resolved the issue with test cases.
@NEC-Vishal just one more favour if you don't mind running the linter locally and fixing whatever it's moaning about, then commit the fixes. The GitHub code linter action is blocking this PR from being merged b/c apparently the linter (autopep8) isn;t happy...
Hi @c0c0n3 I have tried the code linter locally, but linter shows every time requirement already satisfied. also when I run the command sh lint.md.sh showing nothing. so can you Please suggest me a way to solve this?
@NEC-Vishal I've just tried the same locally on your branch and it actually works for me too. I'm going to try overriding the GitHub check so we can merge...
Proposed changes
Added idPattern. Fix for issue #648
Types of changes
What types of changes does your code introduce to the project? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...