added idPattern for issue 648

NEC-Vishal commented 2 years ago

Proposed changes

Added idPattern. Fix for issue #648

Types of changes

What types of changes does your code introduce to the project? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Maintenance (update of libraries or other dependences)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have run all the existing tests locally (not just those related to my feature) and there are no errors
[x] After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
[x] I have updated the RELEASE NOTES
[ ] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

"Martel Open Source Software Individual Contributor License Agreement"

"Contributing to QuantumLeap"

"QuantumLeap Release Notes"

github-actions[bot] commented 2 years ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️

NEC-Vishal commented 2 years ago

Hi @chicco785 @c0c0n3 can you please check the workflow?

c0c0n3 commented 2 years ago

hi @NEC-Vishal! Thank you sooo much for this PR. I've checked out your branch locally and the tests break on my side too. Not sure why. Can you please try running all the tests locally too? Some of them should break for you too, maybe you can help us figure out what's wrong...

NEC-Vishal commented 2 years ago

I have read the CLA Document and I hereby sign the CLA

NEC-Vishal commented 2 years ago

Hi @c0c0n3 @chicco785 can you please check this PR now for issue #648. I have resolved the issue with test cases.

c0c0n3 commented 2 years ago

@NEC-Vishal just one more favour if you don't mind running the linter locally and fixing whatever it's moaning about, then commit the fixes. The GitHub code linter action is blocking this PR from being merged b/c apparently the linter (autopep8) isn;t happy...

NEC-Vishal commented 2 years ago

Hi @c0c0n3 I have tried the code linter locally, but linter shows every time requirement already satisfied. also when I run the command sh lint.md.sh showing nothing. so can you Please suggest me a way to solve this?

c0c0n3 commented 2 years ago

@NEC-Vishal I've just tried the same locally on your branch and it actually works for me too. I'm going to try overriding the GitHub check so we can merge...

orchestracities / ngsi-timeseries-api