Fixed issue 652

[Ravisaketi]

Proposed changes

Replaced entity with getter. Fix for issued #652

Types of changes

What types of changes does your code introduce to the project? Put an x in the boxes that apply

• [ ] Bugfix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Maintenance (update of libraries or other dependences)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• [x] I have read the CONTRIBUTING doc
• [x] I have signed the CLA
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] I have run all the existing tests locally (not just those related to my feature) and there are no errors
• [x] After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
• [x] I have updated the RELEASE NOTES
• [ ] I have added necessary documentation (if appropriate)
• [x] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

"Martel Open Source Software Individual Contributor License Agreement"

"Contributing to QuantumLeap"

"QuantumLeap Release Notes"

[github-actions[bot]]

CLA Assistant Lite bot All contributors have signed the CLA ✍️

[Ravisaketi]

I have read the CLA Document and I hereby sign the CLA.

[Ravisaketi]

Hi @chicco785 @c0c0n3 I have raised a PR for issue #652. can you please check the workflow?

[c0c0n3]

hi @Necravisaketi, it looks like the tests fail for a good reason :-)

UnboundLocalError: local variable 'entity_id' referenced before assignment

Can you try running the tests locally yourself? You should get the same error hopefully...

[Ravisaketi]

Hi, @c0c0n3 as per your suggestions I have updated the PR. Please let me know in case any other change is required to merge this PR.

[c0c0n3]

hi @Necravisaketi :-)

can you please check out my PR review to see if what I said makes any sense? Am I misinterpreting what that TODO was about?

[Ravisaketi]

hi @Necravisaketi :-)

can you please check out my PR review to see if what I said makes any sense? Am I misinterpreting what that TODO was about?

Hi, @c0c0n3 Yes, you're right. sorry for this mistake from my side and I will update this pr.

[c0c0n3]

Hi @Necravisaketi

sorry for this mistake from my side

nothing to be sorry about. when it comes to software things only get clear as you do them, it's a process. At least, that's how it works for me. I often find myself changing direction as my understanding of the problem space gets better along the way. besides, I'm usually the one making mistakes, so I just wanted to double-check w/ you if I understood the problem right...

[c0c0n3]

@Necravisaketi if you could please give me a shout when you're done and think the PR is ready to merge...

[Ravisaketi]

@Necravisaketi if you could please give me a shout when you're done and think the PR is ready to merge...

Hi @c0c0n3, yes, I have already updated this pr. so please review the updated changes.

[c0c0n3]

hi @Necravisaketi I've just had a look at the sql_translator module and bumped into a few more instances of entity ID and type dict access we could replace w/ the entity_id and entity_type functions:

• https://github.com/orchestracities/ngsi-timeseries-api/blob/master/src/translators/sql_translator.py#L473
• https://github.com/orchestracities/ngsi-timeseries-api/blob/master/src/translators/sql_translator.py#L219
• https://github.com/orchestracities/ngsi-timeseries-api/blob/master/src/translators/sql_translator.py#L236
• https://github.com/orchestracities/ngsi-timeseries-api/blob/master/src/translators/sql_translator.py#L471
• https://github.com/orchestracities/ngsi-timeseries-api/blob/master/src/translators/sql_translator.py#L261

hopefully I caught all the instances, but I can't be 100% sure---spahgetti code :-) if you could please double check...thanks a million!!

[Ravisaketi]

Hi, @c0c0n3 I have updated this PR as per your suggestions. so please review the updated changes.

[c0c0n3]

@Necravisaketi I'm merging this PR even if the build failed. In fact, those failures have nothing to do w/ your PR, I've opened separate issues to fix those problems: #666, #674