Closed pooja1pathak closed 2 years ago
Hi @chicco785 @c0c0n3 I have checked the code of test_timescale_type.py and get noting duplicate , also I have checked test files in translator but there is also noting to check . can you please clarify this TODO ?
Hi @chicco785 @c0c0n3
as per my analysis, I found that gen_tenant_id() is common function used in some files of translator and reporter section.
so I am thinking of making a separate file named tenant.py in src/utils and then import that file to all files that contain the duplicate function. this will remove the duplicity in files.
Please guide me!
@NEC-Vishal that's great, thanks a stack. if you could please put the new file in the tests dir, i.e. src/utils/tests/tenant.py
.
@NEC-Vishal that's great, thanks a stack. if you could please put the new file in the tests dir, i.e.
src/utils/tests/tenant.py
.
Hi @c0c0n3 modifications are completed, please check!
Hi @NEC-Vishal, see my comments to #657
Closing as PR #657 is merged.
Remove duplicate code mentioned at:
https://github.com/orchestracities/ngsi-timeseries-api/blob/81351ec96f87175de253dbfc26c8dfbdf3062cd3/src/reporter/tests/test_timescale_types.py#L31