Remove duplicate code mentioned at:ngsi-timeseries-api/src/reporter/tests/test_timescale_types.py

NEC-Vishal commented 2 years ago

Proposed changes

remove the duplicate code in src/reporter/tests/test_timescale_types.py

Types of changes

What types of changes does your code introduce to the project? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Maintenance (update of libraries or other dependences)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[X] I have read the CONTRIBUTING doc
[X] I have signed the CLA
[X] I have added tests that prove my fix is effective or that my feature works
[X] I have run all the existing tests locally (not just those related to my feature) and there are no errors
[X] After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
[X] I have updated the RELEASE NOTES
[X] I have added necessary documentation (if appropriate)
[X] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

"Martel Open Source Software Individual Contributor License Agreement"

"Contributing to QuantumLeap"

"QuantumLeap Release Notes"

github-actions[bot] commented 2 years ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️

NEC-Vishal commented 2 years ago

Hi @chicco785 @c0c0n3 I have raised a PR (pr655) for issue 655 , which removes the duplicity in the code , Please check the workflow. Thanks

c0c0n3 commented 2 years ago

@NEC-Vishal, the CI workflow looks fine, the only thing that's missing is your signing of the CLA, see the GitHub bot's message above. Is there anything else I can help with?

NEC-Vishal commented 2 years ago

I have read the CLA Document and I hereby sign the CLA

c0c0n3 commented 2 years ago

@NEC-Vishal so it looks like we've got a couple of issues

Markdown linter is moaning about extra whitespace: RELEASE_NOTES.md:21 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
Your original code changes went missing? The only thing showing as a change in this PR is a line in the release notes?

Please help! :-)

NEC-Vishal commented 2 years ago

@NEC-Vishal so it looks like we've got a couple of issues

Markdown linter is moaning about extra whitespace: RELEASE_NOTES.md:21 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]

Your original code changes went missing? The only thing showing as a change in this PR is a line in the release notes?

Please help! :-)

hi @c0c0n3 sorry for this mistake at my end while raising PR.

I have updated the PR now, Please check!

c0c0n3 commented 2 years ago

@NEC-Vishal

sorry for this mistake at my end while raising PR

No need to apologise. We all make mistakes, I certainly make more than you. Mistakes just happen, it's a fact of life :-)

Now onto the fun part. The Python linter is failing the PR. I rerun it twice since looking at your code I couldn't see any reason why the linter should complain. But it does. The fun part is that it's not telling me (in CircleCI) the reason it isn't happy. Can you please try running it locally yourself---use lint.py.sh. Hopefully, you should get some more descriptive error...

NEC-Vishal commented 2 years ago

Hi @c0c0n3 @chicco785 can you Please review the updated PR for issue #655 .

c0c0n3 commented 2 years ago

@NEC-Vishal good stuff, thanks so much.

There's still one snag. Like in #653, the GitHub code linter action is blocking this PR from being merged b/c autopep8 sniffed out something. Can you please try running the linter locally and fixing whatever autopep is moaning about, then commit the fixes.

NEC-Vishal commented 2 years ago

Hi @c0c0n3 Like in #653 can we also merge this PR also as all test cases are passed except linter?

c0c0n3 commented 2 years ago

@NEC-Vishal yea, same problem as in #653. no clue what the cause is, but clearly not an issue w/ your code. So I'm merging this PR. Thank you sooo much for your contrib!

orchestracities / ngsi-timeseries-api