Closed Ravisaketi closed 2 years ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️
I have read the CLA Document and I hereby sign the CLA
hi @Necravisaketi :-)
This comment in the translator
TODO: verify: same logic in two different places! The above kinda reproduces the tests done by the translator, we should factor this logic out and keep it in just one place!
is actually outdated. @chicco785 refactored the translators back in the day, so we now have a single place where that logic sits, that is the SQLTranslator.is_text
method. So if you agree I'd actually close this PR and open a new one where we just delete that comment?
@c0c0n3 I got your point. Can I revert the changes, and only remove the comment in this PR only.
Hi, @c0c0n3 @chicco785 As said previously, I revert the changes and removed the comments in sql_translator.py
. please review the changes.
@Necravisaketi excellent, thanks a million! One last favour, can you please rebase on master?
Hi @c0c0n3 can you please check this updated pr.
@Necravisaketi the test_others
task is failing, but I'm merging this PR regardless, since there's no chance in hell your changes could have caused those tests to fail. I've opened a separate issue about it: #666
Proposed changes
is_text method is in utils. fix for issue #659
Types of changes
What types of changes does your code introduce to the project? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...