is_text method is in utils

Ravisaketi commented 2 years ago

Proposed changes

is_text method is in utils. fix for issue #659

Types of changes

What types of changes does your code introduce to the project? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Maintenance (update of libraries or other dependences)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have run all the existing tests locally (not just those related to my feature) and there are no errors
[x] After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
[x] I have updated the RELEASE NOTES
[ ] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

"Martel Open Source Software Individual Contributor License Agreement"

"Contributing to QuantumLeap"

"QuantumLeap Release Notes"

github-actions[bot] commented 2 years ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️

Ravisaketi commented 2 years ago

I have read the CLA Document and I hereby sign the CLA

c0c0n3 commented 2 years ago

hi @Necravisaketi :-)

This comment in the translator

TODO: verify: same logic in two different places! The above kinda reproduces the tests done by the translator, we should factor this logic out and keep it in just one place!

is actually outdated. @chicco785 refactored the translators back in the day, so we now have a single place where that logic sits, that is the SQLTranslator.is_text method. So if you agree I'd actually close this PR and open a new one where we just delete that comment?

Ravisaketi commented 2 years ago

@c0c0n3 I got your point. Can I revert the changes, and only remove the comment in this PR only.

Ravisaketi commented 2 years ago

Hi, @c0c0n3 @chicco785 As said previously, I revert the changes and removed the comments in sql_translator.py. please review the changes.

c0c0n3 commented 2 years ago

@Necravisaketi excellent, thanks a million! One last favour, can you please rebase on master?

Ravisaketi commented 2 years ago

Hi @c0c0n3 can you please check this updated pr.

c0c0n3 commented 2 years ago

@Necravisaketi the test_others task is failing, but I'm merging this PR regardless, since there's no chance in hell your changes could have caused those tests to fail. I've opened a separate issue about it: #666

orchestracities / ngsi-timeseries-api