orchestracities / ngsi-timeseries-api

QuantumLeap: a FIWARE Generic Enabler to support the usage of NGSIv2 (and NGSI-LD experimentally) data in time-series databases
https://quantumleap.rtfd.io/
MIT License
37 stars 49 forks source link

fix for issue #667 #668

Closed NEC-Vishal closed 1 year ago

NEC-Vishal commented 2 years ago

Proposed changes

Resolved TODO at Line 126 of src/reporter/tests/test_timescale_types.py (#667 )

Types of changes

What types of changes does your code introduce to the project? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

"Martel Open Source Software Individual Contributor License Agreement"
"Contributing to QuantumLeap"
"QuantumLeap Release Notes"
github-actions[bot] commented 2 years ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️

NEC-Vishal commented 2 years ago

Hi @c0c0n3 can you Please check this now. I just tried to make the insert_entities same as earlier, for this I need to make change in the test function I change some expected value.

also I add a time wait in geo_queries_fixture.py as it is failing in getting the data.

c0c0n3 commented 2 years ago

hi @NEC-Vishal, nice try, but I think the latest refactoring has more issues than the previous version...but I'm sure you've got good reasons for those changes. Can we have a call to brainstorm about this PR? Just drop me a line to schedule a meeting--- @pooja1pathak has my email address.

I think it's quicker to chat than typing here...

NEC-Vishal commented 1 year ago

Hi @c0c0n3 can you Please check this PR also, as discussed I have updated the PR.

c0c0n3 commented 1 year ago

@NEC-Vishal excellent, thanks a stack!!