orchestracities / ngsi-timeseries-api

QuantumLeap: a FIWARE Generic Enabler to support the usage of NGSIv2 (and NGSI-LD experimentally) data in time-series databases
https://quantumleap.rtfd.io/
MIT License
37 stars 49 forks source link

fix for linter failing #670 #671

Closed Ravisaketi closed 2 years ago

Ravisaketi commented 2 years ago

Proposed changes

fixed for linter failures ( #670 )

Types of changes

What types of changes does your code introduce to the project? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

"Martel Open Source Software Individual Contributor License Agreement"
"Contributing to QuantumLeap"
"QuantumLeap Release Notes"
github-actions[bot] commented 2 years ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️

Ravisaketi commented 2 years ago

Hi, @c0c0n3 we have already discussed the linter failures in previous PRs. now I've fixed the linter failures and now the linter GitHub actions succeeded. So please let me know in case any other change is required to merge this PR.

c0c0n3 commented 2 years ago

@Necravisaketi thanks so much for this fix, much appreciated!!

NOTE. Test failures. The geocoding test in the test_others suite fails, but that's a known issue (#666) and has nothing to do with this PR's the change set. So we're going to ignore that failure and merge anyway.