Closed Ravisaketi closed 1 year ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️
@Necravisaketi thanks for the initial change set, but I think we need something different---see my review comments. Not your fault, the TODO comment was way too cryptic, my bad!!
Hi, @c0c0n3 Thank you for your valuable feedback. I will update this pr as you said.
@Necravisaketi if there's nothing else you'd like to push to this branch I think we're ready to merge? Can you confirm so I can merge this PR?
Notice Coveralls reports a drop of a whooping 10.5% in code coverage. I had a look at the report, not a chance in hell it's accurate---at least not w/r/t your changes. In fact, the report says coverage dropped in most modules, even outside of WQ, so this drop is obviously unrelated to your change set.
@Necravisaketi if there's nothing else you'd like to push to this branch I think we're ready to merge? Can you confirm so I can merge this PR?
Notice Coveralls reports a drop of a whooping 10.5% in code coverage. I had a look at the report, not a chance in hell it's accurate---at least not w/r/t your changes. In fact, the report says coverage dropped in most modules, even outside of WQ, so this drop is obviously unrelated to your change set.
Hi @c0c0n3 Please merge this PR. Thank you.
Proposed changes
Added error handling in src/wq/ql/notify.py fix for issue #673
Types of changes
What types of changes does your code introduce to the project? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...