Closed Ravisaketi closed 1 year ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️
hi @Necravisaketi, I think the TODO was about having a config file with the env var settings in there---i.e. making the settings you can specify through env vars also available in ql-config.yml
. This PR moves the geocoding env vars to a different Python file, so it's a different thing altogether. Should we drop this PR?
@Necravisaketi sorry about this, the TODO wasn't really clear about what to do---pun intended :-)
Proposed changes
Resolved TODO at Line 15 of src/geocoding/factory.py ( #678 )
Types of changes
What types of changes does your code introduce to the project? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...