Resolved issue#678

[Ravisaketi]

Proposed changes

Resolved TODO at Line 15 of src/geocoding/factory.py ( #678 )

Types of changes

What types of changes does your code introduce to the project? Put an x in the boxes that apply

• [ ] Bugfix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Maintenance (update of libraries or other dependences)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• [x] I have read the CONTRIBUTING doc
• [x] I have signed the CLA
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] I have run all the existing tests locally (not just those related to my feature) and there are no errors
• [x] After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
• [x] I have updated the RELEASE NOTES
• [ ] I have added necessary documentation (if appropriate)
• [x] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

"Martel Open Source Software Individual Contributor License Agreement"

"Contributing to QuantumLeap"

"QuantumLeap Release Notes"

[github-actions[bot]]

CLA Assistant Lite bot All contributors have signed the CLA ✍️

[c0c0n3]

hi @Necravisaketi, I think the TODO was about having a config file with the env var settings in there---i.e. making the settings you can specify through env vars also available in ql-config.yml. This PR moves the geocoding env vars to a different Python file, so it's a different thing altogether. Should we drop this PR?

[c0c0n3]

@Necravisaketi sorry about this, the TODO wasn't really clear about what to do---pun intended :-)