Closed Ravisaketi closed 1 year ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️
@Necravisaketi the latest CircleCI build failed b/c of a timeout, but I'm going to merge this PR regardless. Reason: the latest build is for commit d9f5674 which only updated the release notes. On the other hand, the build which tested your change set (601b953) actually succeeded. So we're good to go!
Proposed changes
Resolved TODO at src/transaltors/sql_transaltor.py #694
Types of changes
What types of changes does your code introduce to the project? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...