Fix to return OK/200 and an empty result set when no data found

pooja1pathak commented 9 months ago

Proposed changes

Removed 404 NOT FOUND in when no data found for query and returned 200 OK with empty set. Fix for issue #720 .

Types of changes

What types of changes does your code introduce to the project? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Maintenance (update of libraries or other dependences)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have run all the existing tests locally (not just those related to my feature) and there are no errors
[x] After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
[x] I have updated the RELEASE NOTES
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

"Martel Open Source Software Individual Contributor License Agreement" "Contributing to QuantumLeap" "QuantumLeap Release Notes"

github-actions[bot] commented 9 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️

c0c0n3 commented 9 months ago

@pooja1pathak I've approved your PR but it looks like CircleCI isn't running our tests. Did you run the whole test suite locally? Did it pass?

pooja1pathak commented 9 months ago

@c0c0n3 Yes I've checked and it passed. I have also checked on circle CI, only test_others is showing fail which is not related to my changes. Please find below detail of failing tests:

src/geocoding/tests/test_geocoding.py ......F.F...F. [ 93%]

c0c0n3 commented 9 months ago

@pooja1pathak thanks that's great. I think the problem w/ CircleCI is on our side---not quite sure why, but it might be related to the fact we're merging a branch from your fork since the build seems to work fine if the branch is in the main repo.

re: failing tests, those geocoding tests were failing even before your PR. So I'm merging your PR. Thank you so much for this contrib!!

orchestracities / ngsi-timeseries-api