Closed pooja1pathak closed 2 months ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️
@pooja1pathak thanks for this PR :-)
Can you please confirm you've run the whole test suite, not just the reporter's one? At the moment the CircleCI runner is broken and I haven't managed to run the tests on my laptop.
Also, can you please add a backward-compatibility notice in the release notes along the lines of this one:
thanks so much!
@c0c0n3 I have updated the PR as per your comment. I have run all the tests locally and also checked the CircleCI. Please find below screenshot of the same:
Only test_others is failing, which is not related to my change as you can see in below screenshot:
Can we open new issue for this test_others failure and resolve this error?
Please let me know if any other change is required in this PR.
@pooja1pathak thanks so much! I've just merged your PR into the main branch. If I could ask you one last favour: can you please open an issue about the failing geocoding test in test_others
? Many thanks!!
Proposed changes
added id and type in place of entityId and entityType. Fix for issue #751
Types of changes
What types of changes does your code introduce to the project? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...