orchestral / testbench

Laravel Testing Helper for Packages Development
https://packages.tools/testbench
MIT License
2.11k stars 136 forks source link

Faker not setup after update #374

Closed royduin closed 1 year ago

royduin commented 1 year ago

This one is working: https://github.com/rapidez/core/actions/runs/5791528367/job/15696480561 but since the Testbench update from 7.25 to 7.26 it's not working anymore: https://github.com/rapidez/core/actions/runs/5803677584/job/15732130410. Also with 7.26.2 it's not working: https://github.com/rapidez/core/actions/runs/5827705169/job/15811617310

Somehow Faker setup isn't getting called anymore: https://github.com/laravel/framework/blob/9.x/src/Illuminate/Foundation/Testing/TestCase.php#L151 which we use in our test: https://github.com/rapidez/core/blob/master/tests/Browser/NewsletterTest.php#L11 and now fails as it's null: https://github.com/rapidez/core/blob/master/tests/Browser/NewsletterTest.php#L19

Ideas?

crynobone commented 1 year ago

Please check with the latest Testbench Core 7.26 release.

royduin commented 1 year ago

Same issue: https://github.com/rapidez/core/actions/runs/5827705169/job/15813821107

crynobone commented 1 year ago

Unable to replicate the issue: https://github.com/orchestral/testbench-dusk/commit/fef8914c66a85544ca4ec54d329a6dc562508836

royduin commented 1 year ago

Thank you for your time! I'll look into this further soon and coming back to you.

crynobone commented 1 year ago

It seems that you locked laravel/dusk to ^6.22 while latest orchestra/testbench-dusk requires ^7.7 which causes incompatible. You need to upgrade laravel/dusk to fix the issue

royduin commented 1 year ago

Thank you! It's working 🚀