orchetect / MIDIKit

🎹 Modern multi-platform Swift CoreMIDI wrapper with MIDI 2.0 support.
MIT License
237 stars 32 forks source link

MIDIKitSMF: slow parse time for very big SMF files #208

Open mistydemeo opened 7 months ago

mistydemeo commented 7 months ago

Please Confirm

macOS Version(s) Used to Build

macOS 13 Ventura

Xcode Version(s)

Xcode 14

Description

I'm trying out MIDIKit for the first time, and noticed that parse/load times for very large SMF files seems to be longer than I'd expect. The file I'm loading is 820KB, with 17 MIDI chunks (2097 measures). A test program that consists solely of MIDIFile(midiFile: path) takes about 3.2 seconds to complete in a release build. (Small files are fairly quick to load.)

I recognize that this MIDI is... long... by most standards, so I understand you might not have optimized around it.

Crash Logs, Screenshots or Other Attachments (if applicable)

No response

orchetect commented 7 months ago

This is a known issue. No timeline yet for optimizing the MIDI file module but it's on the to-do list before version 1.0.0.

mistydemeo commented 7 months ago

Aha! Good to know, thank you!