search

orchetect / TimecodeKit

The definitive SMPTE timecode library for Swift.
MIT License
91 stars 8 forks source link

Feature: cocoapods support #68

Closed arshiacont closed 5 months ago

arshiacont commented 1 year ago

Adds a podspec enabling integration in projects with Cocoapods.

For testing, include this line in your Podfile : 

pod 'TimecodeKit', :git => 'https://github.com/arshiacont/TimecodeKit.git', :branch => 'feature/cocoapods'
orchetect commented 1 year ago

pod spec lint is throwing a couple issues:

 -> TimecodeKit (2.0.4)
    - WARN  | github_sources: Github repositories should end in `.git`.
    - ERROR | [iOS] unknown: Encountered an unknown error (CocoaPods could not find compatible versions for pod "TimecodeKit/Core":
  In Podfile:
    TimecodeKit (from `/Users/stef/Desktop/TimecodeKit/TimecodeKit.podspec`) was resolved to 2.0.4, which depends on
      TimecodeKit/Core (= 2.0.4)

Specs satisfying the `TimecodeKit/Core (= 2.0.4)` dependency were found, but they required a higher minimum deployment target.) during validation.
arshiacont commented 10 months ago

Just letting you know that I'll try to find time to finish this up! My pod spec lint has not been working as expected throwing lots of unrelated error since Cocoapods internals is not keeping up with XCode... . This whole story has made us move away from Cocoapods hence the move to a lower priority... . Sorry for the delay!

orchetect commented 10 months ago

That's part of why I didn't attempt to continue support for Cocoapods, but if it's possible to get it working then we can merge.

orchetect commented 6 months ago

I spent a little time trying to see if I could figure this out.

I updated the podspec with the latest metadata and managed to get it to pass pod linting - but only when the Core subspec is the only subspec present.

I tried several solutions to try to get the additional UI subspec to work but wasn't able to get it to work. For now, it's commented out in the podspec.

arshiacont commented 6 months ago

@orchetect thanks for your efforts.

For the SubSpecs I tried to replicate what Firebase does. But it will definitely break the lint!

Confession: Time has passed, XCode has evolved and everything has moved us away from Cocoapods! It's not just the linting process (which I never actually got right for our legacy internal pods).

If there is no request for this feature beside my old request, we can also drop and move to more modern enhancement of your [excellent] projects.

orchetect commented 6 months ago

That's what I was feeling. I wanted to see if it was possible to get it working at this stage before throwing in the towel. But I agree, it's fiddly and probably not worth the time.