search

orchidhq / Orchid

Build and deploy beautiful documentation sites that grow with you
https://orchid.run
GNU General Public License v3.0
517 stars 53 forks source link

Odd dependency on "American-Bible-Society-Client" #219

Closed ericis closed 5 years ago

ericis commented 5 years ago

There's an odd dependency on American-Bible-Society-Client. I haven't reviewed the hierarchy of code and dependencies, but this seems like a very odd one. I actually assumed there was some malware involved somehow, but this looks valid, but unnecessary.

cjbrooks12 commented 5 years ago

No, it's intentional. It's part of the the OrchidBible plugin, which is included in the Orchid-All and Orchid-Language-Pack bundles. It's by no means necessary, and you are free to pick just the plugins you need to exclude the io.github.javaeden.orchid:OrchidBible dependency.

The OrchidBible plugin was one of the earliest ones I added (based on an old library I wrote several years ago) and have just left it there in case anyone wants it. The American-Bible-Society-Client dependency is that old library.