search

orchidhq / Orchid

Build and deploy beautiful documentation sites that grow with you
https://orchid.run
GNU General Public License v3.0
513 stars 53 forks source link

external extraCss support #317

Closed daudazimkhan closed 4 years ago

daudazimkhan commented 4 years ago

For multiple orchid projects, we have to put assets e.g. assets/css/orchidKotlindoc.scss in each project's resources. It would be nice to allow external extraCss so that we dont have to keep duplicates. something like the following should work extraCss:

Right now it says

[WARN] Warnings:
[WARN] AssetHolderDelegate: 
[WARN]     - ../../../../../common-doc/assets/css/orchidKotlindoc.scss is not a valid CSS asset, perhaps you are missing a /assets/css/orchidKotlindoc->css Compiler extension?
cjbrooks12 commented 4 years ago

That is supposed to work, it looks like a bug parsing the file path. I'll have to dig a little more on this.

cjbrooks12 commented 4 years ago

This is a similar root problem to your other issue with the wiki file paths, and the solution will behave similarly. Adding assets will no longer check for "proper" file extensions, and then the referenced asset will resolve to the given filename with the relative path segments removed.

cjbrooks12 commented 4 years ago

This bug has been fixed in 0.17.6.

daudazimkhan commented 4 years ago

Thanks a lot!