orchidjs / tom-select

Tom Select is a lightweight (~16kb gzipped) hybrid of a textbox and select box. Forked from selectize.js to provide a framework agnostic autocomplete widget with native-feeling keyboard navigation. Useful for tagging, contact lists, etc.
https://tom-select.js.org
Apache License 2.0
1.67k stars 125 forks source link

Update bootstrap5 sass #763

Open nblum-mdmi opened 3 months ago

nblum-mdmi commented 3 months ago

This PR addresses some strange behavior I saw around bootstrap 5 styling.

Fixes

Case 1: Border Highlight

If the classes form-select or form-control were applied to the wrapper, then the highlight box around the select would be slightly thinner than should be.

image

image

The issue was not present if form-select or form-control were not provided.

Case 2

When form-select and form-control are omitted the border only changes color when clicked, and no icon is present.

image image

image image

Case 3

When form-select and form-control are present, the highlight box does not appear when focused

image

image

Broken?

My changes are not perfect, as for example:

image image

image image

I don't use sass very often, so open to improvements, but figured I'd give it a first shot. Let me know what you think!