check for traits to report a helpful exception

orchidsoftware / crud

Simplify the process of building CRUD (Create, Read, Update, Delete) functionality in Laravel using the features of Orchid.

https://orchid.software

MIT License

137 stars 34 forks source link

Closed bilogic closed 3 years ago

bilogic commented 3 years ago

Continue from #43

For some reason, after I did a revert, GitHub closed the issue automatically
I was not able to move the checking code into the constructor, the resources and model was not ready and I could not locate the cause through debugging
I made the exception as readable and as meaningful as I could
I think the code is ok as it only adds an 1 config() check during getModelPaginationList(), and disables itself when not debugging

Thanks.

tabuna commented 3 years ago

Hi, what was bad about my proposal? For dependency analysis, we didn't need to create an object.

bilogic commented 3 years ago

@tabuna I could not get it to work inside __construct(), static::$model keeps returning null and throws exception.

tabuna commented 3 years ago

Hi, I have updated this and there will be a release soon that will do hints.