orchidsoftware / platform

Orchid is a @laravel package that allows for rapid application development of back-office applications, admin/user panels, and dashboards.
https://orchid.software
MIT License
4.4k stars 646 forks source link

Roles / Permissions screen and actions after update to 14 #2629

Closed gioacchinopoletto closed 1 year ago

gioacchinopoletto commented 1 year ago

Describe the bug After upgrading to version 14 I have problems with system roles:

despite this:

To Reproduce Steps to reproduce the behavior:

  1. Update to Laravel 14.0.3
  2. Update Orchid CRUD to latest version
  3. Update Orchid Fortify to latest version
  4. Display Roles screen

Expected behavior Correctly display the data present in the database for the roles and be able to modify them since the user used has permissions in the database. I tried a fresh install of Orchid and the screens work fine, for this reason I don't think that this bug depends on System or Browser.

gioacchinopoletto commented 1 year ago

I have made some test and:

any suggestions about this?

tabuna commented 1 year ago

Hi, looked in the actual project what changes were made in the update

// Platform > System > Roles > Role
- Route::screen('roles/{roles}/edit', RoleEditScreen::class)
-     ->name('platform.systems.roles.edit');

+ Route::screen('roles/{role}/edit', RoleEditScreen::class)
+    ->name('platform.systems.roles.edit');

This is due to the fact that the dependency and route resolver now relies on the same principle as in Laravel when using a controller.

Has this change worked for you?

gioacchinopoletto commented 1 year ago

Many thanks @tabuna, I don't have see this! Work perfectly!

PS: we can add a note to upgrade documentation?