orchidsoftware / platform

Orchid is a @laravel package that allows for rapid application development of back-office applications, admin/user panels, and dashboards.
https://orchid.software
MIT License
4.26k stars 631 forks source link

Multiple relation filter with same column name #2791

Open iFrez opened 5 months ago

iFrez commented 5 months ago

Describe the bug After filter apply url have a look like https://domain/admin/method?filter[some_id]=1&filter[some_id]= (Null value in query string leads empty response) instead of https://domain/admin/method?filter[some_id]=1

To Reproduce Steps to reproduce the behavior:

  1. Create columns
    public function columns(): array
    {
    return [
    ...
    TD::make(some_id', 'name')->filter(Relation::make()->fromModel(Method::class, 'column1'),
    TD::make('some_id', 'address')->filter(Relation::make()->fromModel(Method::class, 'column2'),
    ...
       ];
    }
  2. Apply filters

Expected behavior Get clean url like https://domain/admin/method?filter[some_id]=1

Server (please complete the following information):

Additional context Need modify this function to also filter an array and get first not null value. https://github.com/orchidsoftware/platform/blob/e0c7d9e9fc2318f1257125ebf09a6c51b1f05300/resources/js/controllers/filter_controller.js#L83