search

orcnog / orcnog-card-viewer

MIT License
4 stars 0 forks source link

Dealing multiple cards only shows the last 1 #29

Closed joomux closed 6 months ago

joomux commented 9 months ago

I love this module!

I have a card stack that all players can see - the idea is there are 4 cards face up on the table. When I deal from the deck to this stack, on the dealer side all 4 cards are displayed, but on the player side only the last card is displayed. I would have expected the same - 4 cards displayed.

Module: 0.1.8 Foundry: 11.315 image

orcnog commented 6 months ago

Been busy with actual job work, but wanted to leave a comment to let you know I have seen your issue, and I do intend to figure out a solution. This has been on my TODO list, in fact, but it's going to be a hairy fix, so I've been kicking this can down the road for a while. By the token, I'm also open to ideas?

Thanks for the callout - will fix.

davidhawbecker commented 6 months ago

This isn't pressure, just want to add a +1 for this request. This module is amazing and has such great potential. They way Foundry implemented cards is so ugly and this makes it so pretty. So thank you. I wouldn't even consider using the cards in foundry if it weren't for this mod. I can imagine there are a lot of challenges and variables for all type of use cases. In my case this is the same issue I'm running into. I'm running Curse of Strahd and if there's way to show the players 5 face down cards that I control and reveal one by one it would be amazing. I have zero coding experience so I don't have any solutions unfortunately, but I fully support this fix / add. And again thanks for working on this stuff.

orcnog commented 6 months ago

@joomux The latest release should take care of this (well, the original bug noted here), as it groups multiple displayed cards into one view, and likewise shares them in one view.

@davidhawbecker I've got an item on my personal Stretch Goals list that I've named "Watch me Flip", which I believe is what you're suggesting here. Feel free to officially log this as a Feature Request! But you'll be pleased to hear that (other than important bug fixes, if they arise), this feature is essentially my next priority :)