search

ordercloud-api / headstart

A complete and opinionated eCommerce solution using OrderCloud as the backbone - built with .NET Core and Angular
MIT License
31 stars 74 forks source link

Fix a few more docker issues #424

Closed crhistianramirez closed 2 years ago

crhistianramirez commented 2 years ago

These were pointed out to me by JF and I didn't run into them because I had at one point successfully built that layer so it was essentially cached for me. I was able to reproduce by running docker-compose build --no-cache

This fixes two issues

  1. Warnings around package-lock.json being generated by an old version of npm. I switched to the version of node used by the docker container (16.15.0) and re-generated all of the package lock files
  2. Removes layer that runs npm install for buyer and seller UI. This seems to cause issues because the sdk isn't being symlinked and we get errors around @ordercloud/headstart-sdk not being available. Long term I think we might want to think about moving the sdk within each respective projects. There is a little bit of duplicate boilerplate but most of the endpoints called are different and it will simplify many aspects of getting headstart built that currently cause a lot of friction (this being one of them)