ordercloud-api / headstart

A complete and opinionated eCommerce solution using OrderCloud as the backbone - built with .NET Core and Angular
MIT License
31 stars 74 forks source link

Fix small translation bug #444

Closed crhistianramirez closed 2 years ago

crhistianramirez commented 2 years ago

Noticed a bug where after logging out the login page did not have text translated into the last known language I had selected. Reason for this was because the method that implicitly sets the language doesn't also set the cookie

Steps to reproduce:

  1. Log in
  2. Select a language other than default (japanese for example)
  3. Clear your cookies
  4. Log in again
  5. Log out, and see that your selection is not persisted and text on login page is in english

I had some formatting changes so it might be best to review changes by commit