This came up because I have started to refactor the application to update dependencies. The first thing I want to do is remove our dependence on the now deprecated sdk @ordercloud/angular and use just the vanilla javascript sdk everywhere. Some of these references were in old test files. My reasoning for removing them all is that we're not running any tests for any kind of validation. Right now most of these spec files are the ones that are automatically generated by the CLI, the ones that do have test are outdated and broken.
Personally, I would prefer to see end to end tests because they inspire more confidence than unit tests but if we do want unit tests we should probably assume we need to start from ground zero
This came up because I have started to refactor the application to update dependencies. The first thing I want to do is remove our dependence on the now deprecated sdk @ordercloud/angular and use just the vanilla javascript sdk everywhere. Some of these references were in old test files. My reasoning for removing them all is that we're not running any tests for any kind of validation. Right now most of these spec files are the ones that are automatically generated by the CLI, the ones that do have test are outdated and broken.
Personally, I would prefer to see end to end tests because they inspire more confidence than unit tests but if we do want unit tests we should probably assume we need to start from ground zero