With this PR all of our app services along with services from the ordercloud sdk will be tree-shakeable. Meaning if they aren't used in the code they won't be part of the final outputted bundle which means smaller bundle size!
Apart from this we get a couple of other sweet benefits:
services don't have to be defined as provider of a module meaning we can clean up our module.ts files (part of this PR)
tests don't need services explicitly defined as part of the providers array unless they are mocked, meaning cleaner tests (part of this PR)
For Reference #298
Type of change
[ x] Refactor (change/optimize code without changing external behavior)
Checklist:
[ x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ x] New and existing unit tests pass locally with my changes
[ ] I have updated the acceptance criteria on the task so that it can be tested
[ ] I have verified my contribution works and looks well in Firefox, Safari and Internet Explorer
Description
Check this out for more info: https://blog.ninja-squad.com/2018/05/04/what-is-new-angular-6/
With this PR all of our app services along with services from the ordercloud sdk will be tree-shakeable. Meaning if they aren't used in the code they won't be part of the final outputted bundle which means smaller bundle size!
Apart from this we get a couple of other sweet benefits:
For Reference #298
Type of change
Checklist: