Call for User Group Assignments for a non-existent Buyer returns 200

ordercloud-api / ordercloud-dotnet-sdk

The official .NET SDK for the OrderCloud eCommerce platform

MIT License

15 stars 14 forks source link

Call for User Group Assignments for a non-existent Buyer returns 200 #41

Open jlafountaindnw opened 5 years ago

jlafountaindnw commented 5 years ago

If I make a call for a ListPage of UserGroupAssignment objects from a non-existent Buyer like this:

<>.UserGroups.ListUserAssignmentsAsync(<>);

If the buyerID argument is set to a Buyer that is non-existent in OrderCloud, instead of sending back a 404 response, it seems to send back a 200 response along with a ListPage of zero UserGroupAssignment objects.

tmenier commented 5 years ago

Thanks for reporting. I agree, that should probably be a 404. Not an SDK bug per se (it's just echoing what the API returns), but we'll get it logged as an API issue.