search

ordercloud-api / ordercloud-javascript-sdk

The official Javascript SDK for the OrderCloud eCommerce platform
MIT License
16 stars 15 forks source link

Invalid character in error responses' JSON (related with #40) in the AuthAPI #42

Closed cguedes closed 5 years ago

cguedes commented 5 years ago

@crhistianramirez Can you apply this fix to the Auth API? https://github.com/ordercloud-api/OrderCloud-JavaScript-SDK/blob/837a3952a2c7e5c5cdb0434b5e1a3b5a2ed23812/src/Sdk.js#L84

Originally posted by @cguedes in https://github.com/ordercloud-api/OrderCloud-JavaScript-SDK/issues/40#issuecomment-531797241

cguedes commented 5 years ago

CC @ruidfigueiredo

crhistianramirez commented 5 years ago

Hmm it looks like that fix should be in place for the auth api as well: https://github.com/ordercloud-api/OrderCloud-JavaScript-SDK/blob/master/src/Sdk.js#L449

I will have some time later this afternoon to take a second look though.

crhistianramirez commented 5 years ago

@cguedes I was not able to reproduce this https://runkit.com/crhistianramirez/auth-bug-repro

Are you using the latest version (3.5.7)? What are you seeing and what are you expecting?

crhistianramirez commented 5 years ago

Closing this issue. Please feel free to open if you see it the bug on the most recent version