ordinals-wallet / ordinals-collections

A place for creators & builders to organize ordinal collections!
MIT License
756 stars 1.41k forks source link

Looks like there's no other way #2236

Closed StellarStoic closed 1 year ago

StellarStoic commented 1 year ago

I wouldn't open an issue if my pull request for my small collection would've been approved in less then a month and becouse I see there's no particular order and pull requests are skipped, Im complaining why this small and simple project hadn't been merged yet? It really wouldn't take someone more then just a click 🙁

https://github.com/ordinals-wallet/ordinals-collections/pull/1981

cliobitcoinbank commented 1 year ago

Sorry if this is basic, Did you put them both into the correct folder with the name the same as your slug? If your files were valid they should be merged by now.

StellarStoic commented 1 year ago

Sorry if this is basic, Did you put them both into the correct folder with the name the same as your slug? If your files were valid they should be merged by now.

Yes the folder name is the same as the slug. I don't think circleci would pass the test if they were different.

cliobitcoinbank commented 1 year ago

Okay, so was it "TutiFruti Women" or something like that? Seeing an account Golem01, is that you or someone else?

cliobitcoinbank commented 1 year ago

If it was tutifruti women, I notice that the files are in the root directory, and not the correct folders: [collections/inscriptions.json] [collections/meta.json] These two should be changed to [collections/SLUGNAME/inscriptions.json] [collections/SLUGNAME/meta.json] Maybe you are being rejected because your stuff is incorrect, not because maintainers are lazy or biased?

StellarStoic commented 1 year ago

Look at my issue post @cliobitcoinbank ... It's all there, even the link to my collection pull requests which was fone as the specs said it should be done.

What tuti-fruti are you talking about? Golem? What golem? Can't you see what my username is? We're on GitHub, what is stopping you from doin 2-3 extra clicks 😆

cliobitcoinbank commented 1 year ago

Sorry, just trying to get your collection listed because I know how easy and fast it is when everything is done right. I could even do it for you if you are still having trouble, it takes a day or less, I just dont know what project is yours or which project of yours is an ordinals collection. The reason I mentioned that collection and that person is that I'm trying to figure out why your collection is having trouble going thru and I noticed your repository has those 2 files outside of the proper folder, this may be why your collection is not going thru the process successfully, or it could be something else.

StellarStoic commented 1 year ago

Thank you but as I said before. Everything is in my pull request https://github.com/ordinals-wallet/ordinals-collections/pull/1981. (👈 Click here ) I don't know what else do you need 🤷

cliobitcoinbank commented 1 year ago

Whatever, just trying to verify the name and a few other details with you first but I can just copy paste what you already have, just because you passed the tests doesn't mean stuff is correct and that might prevent your collection from getting listed. I apologize that I keep coming at it from the angle that I think something is wrong with the files or formatting, but I am trying to figure out why you are having troubled getting listed by being critical of everything and sometimes assuming that something is wrong. Hopefully the files will be merged by tomorrow. edit: they put your collection thru and closed my duplicate pull request.

StellarStoic commented 1 year ago

It got merged into main 🙏 Thank you @cliobitcoinbank for helping and thank you @chrisconfirm to merge it into main 🫂

cliobitcoinbank commented 1 year ago

Went and checked out your collection now that it is listed, really cool how it generates more combinations that atoms in the universe and all the other deep math stuff that went into them. Definitely much more going on than what you see on the surface with these. Your collection will soon be searchable on OpenOrdex, Ord.io, and Ordinals Wallet just to name three who use this method so far. You can get your collection listed on ordswap's discord channel and I would hurry because they may discontinue collections like yours and mine to "legacy collections" when child parent ords come out as a real defi way of establishing collections. Please please come advertise your collection on the r/BitcoinOrdinals subreddit and just ask ClioBitcoinBank or DaveBra if automod gives you any crap or you need a post approved etc. Great work!

chrisconfirm commented 1 year ago

Hello @StellarStoic , thank you for your patience. Can this issue be closed?