search

ordinals / ord

👁‍🗨 Rare and exotic sats
https://ordinals.com
Creative Commons Zero v1.0 Universal
3.85k stars 1.38k forks source link

Don't allow a user to etch a rune if a valid reveal is in the mempool #3319

Open casey opened 7 months ago

markovichecha commented 7 months ago

How do we handle low fees transactions that can be excluded from mempool or get stuck?

casey commented 7 months ago

I think this is probably relatively low priority, so not necessarily worth doing right away if it's too hard. The best option would probably be to only warn the user if a valid reveal is in the mempool with a higher feerate than the one the user selected, so they can out-bid it.

GaloisField2718 commented 7 months ago

Hello,

Did you removed wallet etch command? It can find it anymore and there are only 3 runes deployed. I need to make some deployment tests. Should I rewrite all the tx worklflow?

casey commented 7 months ago

Runes are now etched with ord wallet inscribe --batch <BATCHFILE>. There are a bunch of parameters, so it isn't practical to specify them in command line arguments.

GaloisField2718 commented 7 months ago

Any requirements for batchfile? Also it will increase the confusion between Runes protocol and ordinal protocol no?

markovichecha commented 7 months ago

Should we maintain a separate index with mempool transactions? I guess it'll take too long if we'll do it on demand. If we are building an index we should enable ZeroMQ to subscribe on new transactions.