ordinals / ord

👁‍🗨 Rare and exotic sats
https://ordinals.com
Creative Commons Zero v1.0 Universal
3.85k stars 1.38k forks source link

How to burn #3989

Open gus4rs opened 1 month ago

gus4rs commented 1 month ago

Guess this is more a usability question than a bug.

Trying to burn an inscription with

ord wallet burn  --fee-rate 20 --postage 1sat <inscription id> 

and am being greeted by

error: JSON-RPC error: RPC error response: RpcError { code: -25, message: "Unspendable output exceeds maximum configured by user (maxburnamount)", data: None }

This is a bitcoin core fart preventing sending funds to OP_RETURN. My understanding is this param (maxburnamount) should be passed to sendrawtransaction, so nothing I can do.

Is the burn feature useless then?

gus4rs commented 1 month ago

If I use the same burn command above but with dry-run then copy the psbt, import it in Sparrow and broadcast, it gets confirmed, and apparently it works

onchainguy-btc commented 1 month ago

Damn. I think to make this work we would need to add support for maxburnamount here.

@raphjaph If you want I can have a look at this together with #3977 this week.

raphjaph commented 1 month ago

Ah damn, our mockcore tests strike again. @onchainguy-btc yes that would be great. Best to split these different issues into separate PRs for easier review.

gus4rs commented 1 month ago

Bro, you seriously didn't try to run the burn command even once for real? 😂

When it comes to Core, an outdated spaghetti full of convoluted flags, work arounds, obnoxious API, this is asking for trouble lol

casey commented 1 month ago

lmao gottem

raphjaph commented 1 month ago

ded

onchainguy-btc commented 1 month ago

💀

gus4rs commented 1 month ago

Become a mock disrespectoor

raphjaph commented 1 month ago

I'm starting to become one

onchainguy-btc commented 1 month ago

Managed to pass the max burn amount on my local ord setup. Now running into this error:

error: JSON-RPC error: RPC error response: RpcError { code: -26, message: "tx-size-small", data: None }

Seems to be related to this issue. Need to investigate further 🤔

onchainguy-btc commented 1 month ago

Works when I add some random bytes to the OP_RETURN output to increase the tx size. @raphjaph before submitting the burn tx, we could check the tx size and only if too small add some bytes. Or do you have a better idea?