search

ordinals / ord

👁‍🗨 Rare and exotic sats
https://ordinals.com
Creative Commons Zero v1.0 Universal
3.86k stars 1.38k forks source link

ordinals.com is now drawing a scrollbar next to each inscription #3990

Closed gmart7t2 closed 3 weeks ago

gmart7t2 commented 1 month ago

Screenshot_2024-10-09_04-03-33

gmart7t2 commented 1 month ago

On Android, too: Screenshot_20241009_040555_Presearch

gmart7t2 commented 1 month ago

It looks like this was introduced by #3947 removing the scrolling=no.

gmart7t2 commented 1 month ago

Size by side comparison of 0.20.0 and 0.20.1: Screenshot_2024-10-09_04-23-28

casey commented 3 weeks ago

I landed a partial fix for this in #4042. The image preview is now fixed, so that the images don't overflow. This should remove all scrollbars on image inscriptions. I also removed scrollbars entirely from inscription thumbnails. This means that the only scrollbars remaining are on non-image inscriptions on /inscription which overflow their bounds. I'm not entirely satisfied with that, since I'm not sure we should have scrollbars at all, especially because they're so ugly on Windows, so I'm going to leave this image open so people have a place to complain about it.

gmart7t2 commented 3 weeks ago

I still see scrollbars on some thumbnails even with scrolling=no on the iframe:

Screenshot_2024-11-04_09-47-31

casey commented 3 weeks ago

Are those on the iframe element itself, or on an interior element of an HTML inscription? I suppose an HTML inscription could have interior content which overflowed the size it's rendered at. But if that's the case, I'm not sure there's much we can do about it, since we don't want to start monkeying with the contents of HTML inscriptions.

casey commented 3 weeks ago

I wrote up the situation in #4048.