Closed casey closed 3 weeks ago
Fixes #3990
@casey
This prevents scrollbars for appearing everywhere except the actual /inscription page
It doesn't. See this example: it has scrolling=no but the thumbnail still displays the scrollbar: https://without21.ordstuff.info/block/868826
That ord server is running origin/master which includes #4042.
In #3947, we allowed scrolling in iframes. I recently visited ordinals.com on windows, and there were hideous scrollbars on nearly every inscription.
This isn't a windows-specific issue, i.e., the scrollbars are there on macOS, they just look worse on Windows, which is why we didn't notice.
This PR does a couple things:
float: left
to images in the image preview. This, for some reason, makes the images the correct size, so they don't overflow, due to some mysterious CSS behavior that I don't fully understand.scrolling=no
to inscription thumbnails. This prevents scrollbars for appearing everywhere except the actual /inscription page, which I think is better. There's no reason to allow scrolling a thumbnail, especially if the user can just click it to scroll.I'm still not sure that we shouldn't just re-add
scrolling=no
to inscriptions. Users can click the content link if they want to scroll, and the bars on windows are absolutely disgusting looking. If you made an HTML inscription, previewed it on an old version of ord, and then inscribed it on mainnet, you're now getting scrollbars where before you didn't see any.However, this PR is a pareto improvement, unlikely removing scrollbars entirely, so I think we should merge this and if the remaining scroll bars are an issue, deal with them later.