ordinals / ord

šŸ‘ā€šŸ—Ø Rare and exotic sats
https://ordinals.com
Creative Commons Zero v1.0 Universal
3.86k stars 1.38k forks source link

Hide image preview and thumbnail scrollbars #4042

Closed casey closed 3 weeks ago

casey commented 3 weeks ago

In #3947, we allowed scrolling in iframes. I recently visited ordinals.com on windows, and there were hideous scrollbars on nearly every inscription.

This isn't a windows-specific issue, i.e., the scrollbars are there on macOS, they just look worse on Windows, which is why we didn't notice.

This PR does a couple things:

I'm still not sure that we shouldn't just re-add scrolling=no to inscriptions. Users can click the content link if they want to scroll, and the bars on windows are absolutely disgusting looking. If you made an HTML inscription, previewed it on an old version of ord, and then inscribed it on mainnet, you're now getting scrollbars where before you didn't see any.

However, this PR is a pareto improvement, unlikely removing scrollbars entirely, so I think we should merge this and if the remaining scroll bars are an issue, deal with them later.

raphjaph commented 3 weeks ago

Fixes #3990

gmart7t2 commented 3 weeks ago

@casey

This prevents scrollbars for appearing everywhere except the actual /inscription page

It doesn't. See this example: it has scrolling=no but the thumbnail still displays the scrollbar: https://without21.ordstuff.info/block/868826

Screenshot_2024-11-04_09-47-31

That ord server is running origin/master which includes #4042.