search

ordinals / ord

👁‍🗨 Rare and exotic sats
https://ordinals.com
Creative Commons Zero v1.0 Universal
3.86k stars 1.38k forks source link

Fix off-by-one-error in sat range template #4075

Closed casey closed 1 week ago

casey commented 1 week ago

Sat ranges are no longer intervals, and instead link to the first and last sat in the range. However, the last sat is off by one. Fix that.

arik-so commented 1 week ago

Wouldn't it be more convenient for consumers of the API if the JSON output also reflected the change to inclusive intervals?

casey commented 1 week ago

@arik-so I think that's a separate issue. The HTML is straightforwardly wrong, since we link directly to the sat which is the end of the interval, and this fixes that.

I think the JSON API is kind of a separate issue, since I think there there's more of an argument that it's a programming interface, and so you want half-open ranges.