ordinals / ord

👁‍🗨 Rare and exotic sats
https://ordinals.com
Creative Commons Zero v1.0 Universal
3.85k stars 1.38k forks source link

Add function to calculate rune unlock height #4097

Open casey opened 18 hours ago

casey commented 18 hours ago

See Rune::unlock_height. This works but makes me nervous. I noticed that my height calculation was one too high whenever we were 0/4, 1/4, 2/4, or 3/4ths of the way through an interval of runes with a given length. So I just fudged it and subtracted one in those cases.

I've exhaustively tested lengths 1 through 7, and they're all correct. (Checked by cross checking with asserts that the result of Rune::unlock_height matches Rune::minimum_at_height.) However, I'm worried that this pattern is actually the result of some deep number theory harmonic integer sequence or something, and is somehow wrong for larger intervals.

t4t5 commented 10 hours ago

I think I know what the issue is. PR opened here: https://github.com/casey/ord/pull/3 👍