search

ordinaryexperts / terraform-aws-hardened-bastion

Terraform module to deploy a security-hardened SSH bastion host in AWS
https://registry.terraform.io/modules/ordinaryexperts/hardened-bastion/aws/latest
1 stars 1 forks source link

Errors running `init` with terraform 0.12.3 #3

Open adamburns7933 opened 5 years ago

adamburns7933 commented 5 years ago

When running terraform init with terraform 0.12.3, I get this error:

Error: Invalid argument name

  on .terraform/modules/bastion/main.tf line 166, in resource "aws_lb_listener" "ssh":
 166:   "default_action" {

Argument names must not be quoted.

It works fine in 0.11.13. Looks like this needs some updates for 0.12 support.

bkono commented 5 years ago

One thing I’ve run across already is that updating for the new 0.12.x syntax will be breaking changes to 0.11.x users. Let’s make sure to be good semver citizens and roll a major.

adamburns7933 commented 5 years ago

@bkono definitely - I've been doing major releases for my other tf 0.12 updates for exactly that reason. In this case, since it's a 0. project, probably we should just bump the minor version. That's what upstream terraform does and technically it still fits within semver since 0. is for 'unstable' apps.