ordo-one / package-benchmark

Swift benchmark runner with many performance metrics and great CI support
Apache License 2.0
326 stars 25 forks source link

chore(patch): [sc-2205] Update to datetime 1.0.1, add iOS target #168

Closed axelandersson closed 1 year ago

axelandersson commented 1 year ago

Description

Updated an #ifdef to not use Jemalloc on iOS.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

shortcut-integration[bot] commented 1 year ago

This pull request has been linked to Shortcut Story #2205: Create iOS/iPad target and make it buildable.

codecov[bot] commented 1 year ago

Codecov Report

Merging #168 (0b08061) into main (3fc3ee1) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/168/graphs/tree.svg?width=650&height=150&src=pr&token=hXHmhEG1iF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one)](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/168?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) ```diff @@ Coverage Diff @@ ## main #168 +/- ## ======================================= Coverage 71.42% 71.42% ======================================= Files 26 26 Lines 3446 3446 ======================================= Hits 2461 2461 Misses 985 985 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/168?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/168?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Last update [3fc3ee1...0b08061](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/168?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one).
github-actions[bot] commented 1 year ago

Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2023-07-04T10:31:41+00:00 Pull request had performance regressions

axelandersson commented 1 year ago

@hassila Removed the libproc.h change. Seems my issue was due to an invalid invocation of swift build to use the iOS SDK.