ordo-one / package-benchmark

Swift benchmark runner with many performance metrics and great CI support
Apache License 2.0
326 stars 25 forks source link

feat(patch): support some IO counters on macOS via proc_pid_rusage() #181

Closed dimlio closed 1 year ago

dimlio commented 1 year ago

Description

Support 2 IO counters on macOS: physical bytes read and written as reported by proc_pid_rusage() --https://opensource.apple.com/source/xnu/xnu-7195.141.2/bsd/sys/resource.h.auto.html https://opensource.apple.com/source/xnu/xnu-7195.141.2/libsyscall/wrappers/libproc/libproc.h.auto.html

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #181 (5b19760) into main (3549c2b) will increase coverage by 0.40%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/181/graphs/tree.svg?width=650&height=150&src=pr&token=hXHmhEG1iF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one)](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) ```diff @@ Coverage Diff @@ ## main #181 +/- ## ========================================== + Coverage 71.29% 71.70% +0.40% ========================================== Files 27 27 Lines 3501 3551 +50 ========================================== + Hits 2496 2546 +50 Misses 1005 1005 ``` | [Files Changed](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [...BenchmarkTests/OperatingSystemAndMallocTests.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-VGVzdHMvQmVuY2htYXJrVGVzdHMvT3BlcmF0aW5nU3lzdGVtQW5kTWFsbG9jVGVzdHMuc3dpZnQ=) | `100.00% <100.00%> (ø)` | | | [Files Changed](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [...BenchmarkTests/OperatingSystemAndMallocTests.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-VGVzdHMvQmVuY2htYXJrVGVzdHMvT3BlcmF0aW5nU3lzdGVtQW5kTWFsbG9jVGVzdHMuc3dpZnQ=) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/181?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/181?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Last update [3549c2b...5b19760](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/181?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one).
github-actions[bot] commented 1 year ago

Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2023-09-07T10:13:33+00:00 Pull request had performance regressions

hassila commented 1 year ago

(also should fix the SwiftLint warnings)