ordo-one / package-benchmark

Swift benchmark runner with many performance metrics and great CI support
Apache License 2.0
326 stars 25 forks source link

feat(minor): Avoid rebuilds #207

Closed hassila closed 11 months ago

hassila commented 11 months ago

Description

We used to unconditionally build all benchmark targets regardless of operation.

Changed logic so that we for baseline read/list/check operations don't rebuild, as we will not execute the benchmark for such operations.

How Has This Been Tested?

Manually tested.

Minimal checklist:

codecov[bot] commented 11 months ago

Codecov Report

Merging #207 (23a32fd) into main (dba4133) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/207/graphs/tree.svg?width=650&height=150&src=pr&token=hXHmhEG1iF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one)](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) ```diff @@ Coverage Diff @@ ## main #207 +/- ## ======================================= Coverage 70.40% 70.40% ======================================= Files 29 29 Lines 3909 3909 ======================================= Hits 2752 2752 Misses 1157 1157 ``` | [Files](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [Tests/BenchmarkTests/AdditionalTests.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-VGVzdHMvQmVuY2htYXJrVGVzdHMvQWRkaXRpb25hbFRlc3RzLnN3aWZ0) | `100.00% <100.00%> (ø)` | | | [Files](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [Tests/BenchmarkTests/AdditionalTests.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-VGVzdHMvQmVuY2htYXJrVGVzdHMvQWRkaXRpb25hbFRlc3RzLnN3aWZ0) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/207?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/207?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Last update [dba4133...23a32fd](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/207?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one).
github-actions[bot] commented 11 months ago

Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2023-12-15T11:04:27+00:00 Pull request had performance regressions