ordo-one / package-benchmark

Swift benchmark runner with many performance metrics and great CI support
Apache License 2.0
326 stars 25 forks source link

fix(patch): Fix incorrect public export of Lock #217

Closed hassila closed 10 months ago

hassila commented 10 months ago

Description

Make the SwiftNIO borrowed Lock non-public, should definitely not be exported.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

codecov[bot] commented 10 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (c53cdca) 67.18% compared to head (617259b) 67.18%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/217/graphs/tree.svg?width=650&height=150&src=pr&token=hXHmhEG1iF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one)](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) ```diff @@ Coverage Diff @@ ## main #217 +/- ## ======================================= Coverage 67.18% 67.18% ======================================= Files 34 34 Lines 4376 4376 ======================================= Hits 2940 2940 Misses 1436 1436 ``` | [Files](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [Sources/Benchmark/NIOConcurrencyHelpers/lock.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvTklPQ29uY3VycmVuY3lIZWxwZXJzL2xvY2suc3dpZnQ=) | `1.75% <0.00%> (ø)` | | | [Files](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [Sources/Benchmark/NIOConcurrencyHelpers/lock.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvTklPQ29uY3VycmVuY3lIZWxwZXJzL2xvY2suc3dpZnQ=) | `1.75% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/217?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/217?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Last update [c53cdca...617259b](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/217?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one).
github-actions[bot] commented 10 months ago

Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-01-08T16:18:17+00:00 Pull request had performance regressions