search

ordo-one / package-benchmark

Swift benchmark runner with many performance metrics and great CI support
Apache License 2.0
326 stars 25 forks source link

Signpost for startBenchmark/stopBenchmark #259

Closed dnadoba closed 3 months ago

dnadoba commented 3 months ago

The signposts introduced in https://github.com/ordo-one/package-benchmark/pull/182 are very valuable. It would be great if they would also respect if the benchmark is stared/stoped manually. I guess this requires another set of signposts as we don't know upfront if Benchmark.startBenchmark() is called or not.

hassila commented 3 months ago

That's a good idea. Don't remember the details of the signpost api, but you are likely right.

hassila commented 3 months ago

@dnadoba fixed in https://github.com/ordo-one/package-benchmark/pull/260