ordo-one / package-benchmark

Swift benchmark runner with many performance metrics and great CI support
Apache License 2.0
326 stars 25 forks source link

feat(minor): Add signposts for explicit starts #260

Closed hassila closed 3 months ago

hassila commented 3 months ago

Description

Adding support for per-iteration signposts as requested in https://github.com/ordo-one/package-benchmark/issues/259

How Has This Been Tested?

Manually verified.

Minimal checklist:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.32%. Comparing base (f03eaa2) to head (69e56e4).

Files Patch % Lines
Sources/Benchmark/Benchmark.swift 80.00% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/260/graphs/tree.svg?width=650&height=150&src=pr&token=hXHmhEG1iF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one)](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) ```diff @@ Coverage Diff @@ ## main #260 +/- ## ========================================== + Coverage 65.30% 65.32% +0.01% ========================================== Files 33 33 Lines 3597 3610 +13 ========================================== + Hits 2349 2358 +9 - Misses 1248 1252 +4 ``` | [Files](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/260?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [Sources/Benchmark/BenchmarkExecutor.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/260?src=pr&el=tree&filepath=Sources%2FBenchmark%2FBenchmarkExecutor.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrRXhlY3V0b3Iuc3dpZnQ=) | `90.73% <100.00%> (+0.28%)` | :arrow_up: | | [Sources/Benchmark/Benchmark.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/260?src=pr&el=tree&filepath=Sources%2FBenchmark%2FBenchmark.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrLnN3aWZ0) | `66.98% <80.00%> (-2.63%)` | :arrow_down: | | [Files](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/260?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) | Coverage Δ | | |---|---|---| | [Sources/Benchmark/BenchmarkExecutor.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/260?src=pr&el=tree&filepath=Sources%2FBenchmark%2FBenchmarkExecutor.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrRXhlY3V0b3Iuc3dpZnQ=) | `90.73% <100.00%> (+0.28%)` | :arrow_up: | | [Sources/Benchmark/Benchmark.swift](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/260?src=pr&el=tree&filepath=Sources%2FBenchmark%2FBenchmark.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one#diff-U291cmNlcy9CZW5jaG1hcmsvQmVuY2htYXJrLnN3aWZ0) | `66.98% <80.00%> (-2.63%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/260?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/260?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Last update [f03eaa2...69e56e4](https://app.codecov.io/gh/ordo-one/package-benchmark/pull/260?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ordo-one).
github-actions[bot] commented 3 months ago

Pull request had an unknown failure Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-08-13T10:00:45+00:00